Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upload-bin, NeoFSBlockFetcher: migrate to SEARCH with strict equality comparator #3691

Merged
merged 4 commits into from
Nov 25, 2024
Merged

upload-bin, NeoFSBlockFetcher: migrate to SEARCH with strict equality comparator #3691

merged 4 commits into from
Nov 25, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3670

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 82.95%. Comparing base (ff15e39) to head (43609dd).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
cli/util/upload_bin.go 0.00% 39 Missing ⚠️
pkg/services/blockfetcher/blockfetcher.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3691      +/-   ##
==========================================
- Coverage   83.04%   82.95%   -0.10%     
==========================================
  Files         335      335              
  Lines       46719    46730      +11     
==========================================
- Hits        38800    38767      -33     
- Misses       6327     6373      +46     
+ Partials     1592     1590       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

AnnaShaleva
AnnaShaleva reviewed Nov 20, 2024
View reviewed changes
cli/util/upload_bin.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva requested changes Nov 20, 2024
View reviewed changes
cli/util/upload_bin.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 20, 2024
View reviewed changes
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
pkg/services/blockfetcher/blockfetcher.go Outdated Show resolved Hide resolved
pkg/services/blockfetcher/blockfetcher.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 20, 2024
View reviewed changes
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 20, 2024
View reviewed changes
cli/util/upload_bin.go Outdated Show resolved Hide resolved
roman-khimov
roman-khimov reviewed Nov 21, 2024
View reviewed changes
cli/util/upload_bin.go Show resolved Hide resolved
cli/util/upload_bin.go Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
@AliceInHunterland AliceInHunterland force-pushed the uploader-eq-search branch 2 times, most recently from 4338ad8 to f9bed27 Compare November 21, 2024 15:01
@AliceInHunterland AliceInHunterland force-pushed the uploader-eq-search branch 2 times, most recently from 0f03ee9 to c131187 Compare November 21, 2024 16:18
AnnaShaleva
AnnaShaleva reviewed Nov 22, 2024
View reviewed changes
cli/util/upload_bin.go Outdated Show resolved Hide resolved
cli/util/upload_bin.go Outdated Show resolved Hide resolved
pkg/services/blockfetcher/blockfetcher.go Outdated Show resolved Hide resolved
@AliceInHunterland AliceInHunterland force-pushed the uploader-eq-search branch 3 times, most recently from 093f853 to 6f3189f Compare November 22, 2024 10:21
@AnnaShaleva
Copy link
Member

@AliceInHunterland linter is failing.

@AliceInHunterland
cli: fix nil error of fetchLatestMissingBlockIndex in upload-bin
9fd375d 
Close #3653

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland
cli: split searchBatchSize usage in upload-bin command
5dab154 
Split searchBatchSize into constant for searching and uploading.

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland
cli: refactor index file search in upload-bin command
616c805 
Align index file searching logic with block search.

Signed-off-by: Ekaterina Pavlova <[email protected]>
AnnaShaleva
AnnaShaleva reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Have you tested it, does it work?

cli/util/upload_bin.go Outdated Show resolved Hide resolved
@AliceInHunterland
Copy link
Contributor Author

AliceInHunterland commented Nov 25, 2024 •
edited
Loading

LGTM otherwise. Have you tested it, does it work?

yep, it's a really slow search for the last missing block. But works fine.

@AnnaShaleva AnnaShaleva merged commit 171e01b into master Nov 25, 2024
32 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the uploader-eq-search branch November 25, 2024 10:43
@AnnaShaleva AnnaShaleva mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate upload-bin and NeoFSBlockFetcher from SEARCH for range to SEARCH with strict equality comparator
3 participants
@AliceInHunterland @AnnaShaleva @roman-khimov