Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: fix packmap operation #3685

Merged
merged 1 commit into from
Nov 19, 2024
Merged

vm: fix packmap operation #3685

merged 1 commit into from
Nov 19, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3613

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.00%. Comparing base (176593b) to head (9082c6e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/vm/vm.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3685      +/-   ##
==========================================
- Coverage   83.05%   83.00%   -0.05%     
==========================================
  Files         334      334              
  Lines       46604    46603       -1     
==========================================
- Hits        38705    38681      -24     
- Misses       6320     6348      +28     
+ Partials     1579     1574       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@AliceInHunterland AliceInHunterland marked this pull request as ready for review November 15, 2024 07:53
AnnaShaleva
AnnaShaleva reviewed Nov 15, 2024
View reviewed changes
pkg/rpcclient/nep11/base_test.go Outdated Show resolved Hide resolved
pkg/vm/vm.go Outdated Show resolved Hide resolved
pkg/vm/vm.go Outdated Show resolved Hide resolved
pkg/vm/stackitem/item.go Outdated Show resolved Hide resolved
@AnnaShaleva
Copy link
Member

Add a designated compatibility test, please.

@AliceInHunterland AliceInHunterland force-pushed the vm-map branch 3 times, most recently from 89c94c4 to 2703b6f Compare November 18, 2024 12:02
AnnaShaleva
AnnaShaleva reviewed Nov 18, 2024
View reviewed changes
pkg/vm/stackitem/item_test.go Outdated Show resolved Hide resolved
pkg/vm/stackitem/json_test.go Outdated Show resolved Hide resolved
pkg/vm/vm.go Outdated Show resolved Hide resolved
pkg/vm/vm_test.go Outdated Show resolved Hide resolved
pkg/vm/vm_test.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva reviewed Nov 19, 2024
View reviewed changes
pkg/vm/vm.go Outdated Show resolved Hide resolved
@AliceInHunterland
vm: fix PACKMAP operation
9082c6e 
Close #3613

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AnnaShaleva AnnaShaleva merged commit 2b1b9a4 into master Nov 19, 2024
32 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the vm-map branch November 19, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packmap operation keeps duplicate entries
2 participants
@AliceInHunterland @AnnaShaleva