*: remove range usage from smartcontracts #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3680 +/- ##
==========================================
+ Coverage 83.05% 83.13% +0.07%
==========================================
Files 334 334
Lines 46599 46599
==========================================
+ Hits 38705 38738 +33
+ Misses 6320 6286 -34
- Partials 1574 1575 +1 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Nov 14, 2024
AliceInHunterland
force-pushed
the
fix-range
branch
from
cec37f3 to
5435f52
Compare
AliceInHunterland
changed the title
Reverting a part of 1b83dc2, because ranging over integers is not supported by smart contract compiler, ref. #3525. Close #3671 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
fix-range
branch
from
5435f52 to
71a89c2
Compare
AnnaShaleva
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting a part of 1b83dc2, because ranging over integers is not supported by smart contract compiler, ref. #3525.
Close #3671