Dependency upgrade #3570
Merged
Dependency upgrade #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
reviewed
Sep 4, 2024
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
It's maintained now again! A lot of fixes went in, but it seems to be ok in tests. Signed-off-by: Roman Khimov <[email protected]>
Heavily optimized one. Signed-off-by: Roman Khimov <[email protected]>
go-ordered-json and rfc6979, nothing has really changed there. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Minor fixes and Go 1.22. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Which allows to drop two direct dependencies specific to scripts from the main go.mod. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
dep-upgrade
branch
from
7ce02c5 to
f614cc3
Compare
AnnaShaleva
previously approved these changes
Sep 4, 2024
AnnaShaleva
dismissed
their stale review
Interop dependencies are not updated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3570 +/- ##
==========================================
- Coverage 85.85% 85.77% -0.08%
==========================================
Files 330 330
Lines 38537 38537
==========================================
- Hits 33085 33056 -29
- Misses 3904 3933 +29
Partials 1548 1548 ☔ View full report in Codecov by Sentry. |
vX.Y.Z-date-commit is very much different from vX.Y.Z and we can have any of them for NeoGo (vX.Y.Z is even preferable). Previous code ended up this way for v0.106.3: ++ sed -E -n -e 's/.*neo-go\s.+-.+-(\w+)/\1/ p' examples/nft-nd-nns//go.mod + NEO_GO_COMMIT= + git merge-base --is-ancestor '' HEAD fatal: Not a valid object name + die 'examples/nft-nd-nns/: neo-go commit was not found in git' + echo 'examples/nft-nd-nns/: neo-go commit was not found in git' examples/nft-nd-nns/: neo-go commit was not found in git + exit 1 Signed-off-by: Roman Khimov <[email protected]>
AnnaShaleva
approved these changes
Sep 4, 2024
AliceInHunterland
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Outdated dependencies.
Solution
Upgrade them.