Go 1.22 #3567
Merged
Go 1.22 #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes workflows to test 1.22 and 1.23 only (refs. nspcc-dev/.github#30). Fixes #3310. Signed-off-by: Roman Khimov <[email protected]>
LIkely it's more readable this way. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
It's slightly less efficient (all comparisons are always made), but for strings/ints it's negligible performance difference, while the code looks a tiny bit better. Signed-off-by: Roman Khimov <[email protected]>
Mostly this switches to math/rand/v2, but sometimes randomness is not really needed. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
It's a bit easier this way, loops that change slices aren't fun. Signed-off-by: Roman Khimov <[email protected]>
Mostly it's about Go 1.22+ syntax with ranging over integers, but it also prefers ranging over slices where possible (it makes code a little better to read). Notice that we have a number of dangerous loops where slices are mutated during loop execution, many of these can't be converted since we need proper length evalutation at every iteration. Signed-off-by: Roman Khimov <[email protected]>
It's unused. Maybe we can move it out of VM completely decoupling VM from crypto. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3567 +/- ##
=======================================
Coverage 85.79% 85.79%
=======================================
Files 330 330
Lines 38539 38537 -2
=======================================
- Hits 33063 33062 -1
+ Misses 3930 3928 -2
- Partials 1546 1547 +1 ☔ View full report in Codecov by Sentry. |
Go 1.22+ allows to drop these: The copy of the 'for' variable "i" can be deleted (Go 1.22+) (copyloopvar) Signed-off-by: Roman Khimov <[email protected]>
AnnaShaleva
approved these changes
Sep 2, 2024
AliceInHunterland
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.