docs: adjust DB compatibility notes #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's dangerous to change `Max*` ProtocolConfiguration settings: * Changes in MaxBlockSize, MaxBlockSystemFee and MaxTransactionsPerBlock may lead to the fact that accepted block or transaction becomes invalid. I agree that these settings are not written in the DB, but at the same time it's not correct to compare databases that have these settings mismatched. * Changes in MaxTraceableBlocks may lead to the fact that some transaction will be processed differently, it's a possible contract state mismatch. * Changes in MaxValidUntilBlockIncrement may lead to the fact that `setMaxNotValidBeforeDelta` method of native Notary contract may be processed in a different way which is also a possible contract state mismatch. Ref. 5d29a3f. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added
documentation
roman-khimov
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's dangerous to change
Max*ProtocolConfiguration settings:setMaxNotValidBeforeDeltamethod of native Notary contract may be processed in a different way which is also a possible contract state mismatch.Ref. 5d29a3f.