Fix mempool fees #3537
Merged
Fix mempool fees #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used and not needed for removal. Signed-off-by: Roman Khimov <[email protected]>
Metrics should be updated once per action, currently removeInternal is used by Add and Remove, the first one updates them in the end anyway and remove should do the same. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3537 +/- ##
==========================================
- Coverage 86.08% 86.05% -0.04%
==========================================
Files 330 330
Lines 38678 38678
==========================================
- Hits 33297 33284 -13
- Misses 3840 3849 +9
- Partials 1541 1545 +4 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
approved these changes
Jul 31, 2024
Fixes #3488. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
fix-mempool-fees
branch
from
89ae319 to
5d1d7b1
Compare
AnnaShaleva
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed pretty much accidentally.