logs: hide timestamp if the program is run not in TTY #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3468 +/- ##
==========================================
- Coverage 86.19% 86.14% -0.06%
==========================================
Files 331 331
Lines 38470 38473 +3
==========================================
- Hits 33159 33141 -18
- Misses 3778 3803 +25
+ Partials 1533 1529 -4 ☔ View full report in Codecov by Sentry. |
|
We need this to be dependent on tty. |
AnnaShaleva
reviewed
May 31, 2024
AnnaShaleva
reviewed
May 31, 2024
There was a problem hiding this comment.
@AliceInHunterland, fix the commit message and PR title. It's not "by default".
AliceInHunterland
force-pushed
the
logs
branch
2 times, most recently
from
4b3ec13 to
673aa30
Compare
If the program is run in TTY then logger adds timestamp to its entries. Close #3358 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
changed the title
AnnaShaleva
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3358