network: take care of TestServerStartAndShutdown #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have a reliable way to know when transports are started since their start is being performed in a separate goroutine: https://github.com/nspcc-dev/neo-go/blob/927dbb6dc48d578ae731e5a067c82d0611642338/pkg/network/server.go#L297-L299 And transports start is not connected with main server routine, thus, just wait for some time for the transports goroutine to be started. Also wait for the peer to be properly registered. Close #3399. Signed-off-by: Anna Shaleva <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3400 +/- ##
==========================================
- Coverage 84.86% 84.77% -0.09%
==========================================
Files 331 331
Lines 44972 44972
==========================================
- Hits 38164 38127 -37
- Misses 5292 5330 +38
+ Partials 1516 1515 -1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have a reliable way to know when transports are started since their start is being performed in a separate goroutine:
neo-go/pkg/network/server.go
Lines 297 to 299 in 927dbb6
And transports start is not connected with main server routine, thus, just wait for some time for the transports goroutine to be started.
Also wait for the peer to be properly registered.
Close #3399.