rpcsrv: fix findstorage if a contract state is not found #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3385 +/- ##
=======================================
Coverage 84.80% 84.80%
=======================================
Files 331 331
Lines 44967 44969 +2
=======================================
+ Hits 38133 38138 +5
+ Misses 5325 5319 -6
- Partials 1509 1512 +3 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Apr 2, 2024
AliceInHunterland
force-pushed
the
findstorage
branch
from
893c8c8 to
94aceaf
Compare
AnnaShaleva
reviewed
Apr 2, 2024
pkg/services/rpcsrv/server.go
Outdated
| @@ -1750,7 +1750,8 @@ func (s *Server) findStorageInternal(id int32, prefix []byte, start, take int, s | |||
| var ( | |||
| i int | |||
| end = start + take | |||
| res = new(result.FindStorage) | |||
| // Results is an empty list if a contract state is not found as it is in C# implementation. | |||
There was a problem hiding this comment.
s/Results/res (if referring to a var) or s/Results is/Result is (if talking about generic operation result).
Previously findstorage returns null for the results key if a contract state is not found. C# returns an empty list. Close #3370 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
findstorage
branch
from
94aceaf to
fff25bd
Compare
AnnaShaleva
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3370