rpcsrv: fix TestRPC failing #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AliceInHunterland
force-pushed
the
test-dial
branch
from
79956cc to
8babcca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3368 +/- ##
==========================================
- Coverage 84.82% 84.80% -0.03%
==========================================
Files 331 331
Lines 44961 44961
==========================================
- Hits 38139 38129 -10
- Misses 5312 5319 +7
- Partials 1510 1513 +3 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
force-pushed
the
test-dial
branch
from
8babcca to
5476237
Compare
AnnaShaleva
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Good, it may help. It also may help with #3314, ref. #3314 (comment). Add a closing link to macOS test.
Default http.Client and http.Transport can be really slow. Also on windows Timeout: time.Second was not enough. Probably network related issue. As mentioned in https://github .com//issues/2975#issuecomment-1750523651 forcely use only tcp4 and FallbackDelay: -1. This made TestRPC little bit faster so gh windows runner can manage it without timeout or POST request fails. Close #2975 Close #3314 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
test-dial
branch
from
5476237 to
f409fc3
Compare
|
Very nice, only codecove is failing, but it's coverage-related issue. |
AnnaShaleva
approved these changes
Mar 22, 2024
This was referenced Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the empirical selection of parameters got #3367 so seems rpc test package is still big and therefore slow for gh windows runner. But with setup in this commit haven't got test timeout yet.
Close #2975.
Close #3314.