rpcsrv: fix concurrent test TestClient_IteratorSessions #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
- Coverage 84.67% 84.67% -0.01%
==========================================
Files 331 331
Lines 44932 44932
==========================================
- Hits 38047 38046 -1
Misses 5373 5373
- Partials 1512 1513 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Mar 9, 2024
AnnaShaleva
reviewed
Mar 11, 2024
|
Please, rebase onto fresh master. |
AliceInHunterland
force-pushed
the
concurrent-test
branch
from
1175a93 to
5a36caf
Compare
The default for `MaxConnsPerHost` is "no limit", so it'll use as many connections as it can (potentially hitting MacOS/Windows limits golang/go#20960 (comment) ). Close #3300 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
concurrent-test
branch
from
5a36caf to
588d7c6
Compare
AnnaShaleva
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3300