smartcontract: introduce Convertible interface #3297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
sc-convertible
branch
from
b6da21e to
9271e31
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3297 +/- ##
==========================================
+ Coverage 85.16% 85.19% +0.03%
==========================================
Files 327 327
Lines 44448 44459 +11
==========================================
+ Hits 37854 37878 +24
+ Misses 5095 5074 -21
- Partials 1499 1507 +8 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
changed the title
Allow to pass Convertible to NewParameterFromValue. Close #3285. Signed-off-by: Anna Shaleva <[email protected]>
Run error cases in the same loop with test cases. No functional changes. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
sc-convertible
branch
from
9271e31 to
136fb5e
Compare
AliceInHunterland
approved these changes
Jan 23, 2024
pkg/rpcclient/nns/record.go
Outdated
| @@ -33,6 +39,14 @@ const ( | |||
| AAAA RecordType = 28 | |||
| ) | |||
|
|
|||
| // ToParameter implements smartcontract.Convertible interface. | |||
There was a problem hiding this comment.
not ToSCParameter instead of ToParameter?
Implement smartcontract.Convertible for nns.RecordType. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
sc-convertible
branch
from
136fb5e to
161b83f
Compare
AliceInHunterland
approved these changes
Jan 25, 2024
roman-khimov
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3285. Needed for proper #3291 handling.