Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neotest: fix NewSingleSigner description, fix #3118 #3119

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

roman-khimov
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #3119 (7cedcb9) into master (a59fd50) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 81.00%.

@@           Coverage Diff           @@
##           master    #3119   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         330      330           
  Lines       44349    44323   -26     
=======================================
- Hits        37655    37633   -22     
+ Misses       5179     5175    -4     
  Partials     1515     1515           
Files Changed Coverage Δ
pkg/neotest/signer.go 74.35% <ø> (ø)
pkg/network/notary_feer.go 100.00% <ø> (ø)
pkg/services/rpcsrv/server.go 80.92% <ø> (ø)
pkg/core/dao/dao.go 79.03% <60.00%> (-0.07%) ⬇️
pkg/core/mempool/mem_pool.go 97.14% <98.07%> (-0.12%) ⬇️
pkg/core/blockchain.go 78.63% <100.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tatiana-nspcc tatiana-nspcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but maybe you want to change pull request description?

@roman-khimov
Copy link
Member Author

When there is a single commit in a branch GH always takes complete description from it. And I don't mind.

@roman-khimov roman-khimov merged commit 2f54f17 into master Sep 5, 2023
@roman-khimov roman-khimov deleted the neotest-doc branch September 5, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants