compiler: fix sequence point boundaries #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
added
bug
AnnaShaleva
force-pushed
the
fix-debug-info
branch
from
3d32360 to
a8201c0
Compare
Thanks to @fyrchik, see the https://github.com/neo-project/neo-devpack-dotnet/pull/154/files#diff-ebf53d00d5ba1f1197fedd2b8111fe9a8f44fb96699ef1314d54d05d5ceeb3f3R27 See also the standard: https://github.com/neo-project/proposals/blob/master/nep-19.mediawiki#method. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
fix-debug-info
branch
from
a8201c0 to
d1fe644
Compare
|
I'm not sure which test can be added for this, i've just checked the proposal and the C# compiler implementation, it should be the column. |
Codecov Report
@@ Coverage Diff @@
## master #3074 +/- ##
==========================================
- Coverage 84.70% 84.66% -0.04%
==========================================
Files 329 329
Lines 43941 43941
==========================================
- Hits 37219 37202 -17
- Misses 5216 5228 +12
- Partials 1506 1511 +5
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
It can only be tested with the actual debugger. |
roman-khimov
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @fyrchik, see the
https://github.com/neo-project/neo-devpack-dotnet/pull/154/files#diff-ebf53d00d5ba1f1197fedd2b8111fe9a8f44fb96699ef1314d54d05d5ceeb3f3R27
Not tested yet, need to take more careful look at it.