Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: support System.Runtime.CurrentSigners syscall #3058

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Jul 8, 2023

Port neo-project/neo#2827.

Draft until the reference implementation is merged.

TODO:

  • Update internal dependencies after PR finalization.

@AnnaShaleva AnnaShaleva added this to the v0.102.0 milestone Jul 8, 2023
@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b220594) 85.39% compared to head (06c99fb) 85.40%.

Files Patch % Lines
pkg/core/transaction/signer.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3058      +/-   ##
==========================================
+ Coverage   85.39%   85.40%   +0.01%     
==========================================
  Files         326      326              
  Lines       43785    43793       +8     
==========================================
+ Hits        37389    37402      +13     
+ Misses       4922     4918       -4     
+ Partials     1474     1473       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov
Copy link
Member

OK if nothing changes in the C# PR.

@roman-khimov roman-khimov modified the milestones: v0.102.0, v0.104.0 Sep 6, 2023
@AnnaShaleva AnnaShaleva modified the milestones: v0.105.0, v0.104.0 Nov 9, 2023
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva marked this pull request as ready for review November 20, 2023 11:51
@roman-khimov roman-khimov merged commit 48bd805 into master Nov 20, 2023
15 of 18 checks passed
@roman-khimov roman-khimov deleted the current-signers branch November 20, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants