Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: allow to emit stackitem.Convertible #3016

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

AnnaShaleva
Copy link
Member

Close #2987.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #3016 (fc6029d) into master (d493afc) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3016      +/-   ##
==========================================
+ Coverage   84.63%   84.75%   +0.12%     
==========================================
  Files         328      328              
  Lines       43176    43359     +183     
==========================================
+ Hits        36542    36751     +209     
+ Misses       5145     5114      -31     
- Partials     1489     1494       +5     
Impacted Files Coverage Δ
pkg/smartcontract/builder.go 100.00% <ø> (ø)
pkg/rpcclient/notary/contract.go 100.00% <100.00%> (ø)
pkg/vm/emit/emit.go 94.57% <100.00%> (+1.79%) ⬆️
pkg/vm/stackitem/item.go 90.05% <100.00%> (+0.14%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AnnaShaleva AnnaShaleva force-pushed the emit-convertible branch 2 times, most recently from 1f60dd5 to 19ad979 Compare May 16, 2023 10:18
@AnnaShaleva AnnaShaleva requested a review from roman-khimov May 16, 2023 10:21
@AnnaShaleva AnnaShaleva force-pushed the emit-convertible branch 2 times, most recently from 9948e44 to 06a7060 Compare May 16, 2023 10:31
@AnnaShaleva
Copy link
Member Author

I'll add some more tests.

@AnnaShaleva AnnaShaleva marked this pull request as draft May 17, 2023 09:30
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva requested a review from roman-khimov May 17, 2023 09:47
@AnnaShaleva AnnaShaleva marked this pull request as ready for review May 17, 2023 09:47
@roman-khimov roman-khimov merged commit 7b86a54 into master May 17, 2023
@roman-khimov roman-khimov deleted the emit-convertible branch May 17, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notary: Example deposit code is currently unworkable
2 participants