Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wsclient handshake error #2821

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Conversation

roman-khimov
Copy link
Member

Problem

#2818

Solution

Add a new server-side configuration as well.

@roman-khimov roman-khimov added rpc RPC server and client config Configuration format update or breaking change labels Nov 23, 2022
@roman-khimov roman-khimov added this to the v0.100.0 milestone Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #2821 (327dfb8) into master (ab0b236) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2821      +/-   ##
==========================================
+ Coverage   84.83%   84.84%   +0.01%     
==========================================
  Files         327      327              
  Lines       41534    41545      +11     
==========================================
+ Hits        35234    35250      +16     
+ Misses       4861     4857       -4     
+ Partials     1439     1438       -1     
Impacted Files Coverage Δ
pkg/rpcclient/wsclient.go 63.36% <100.00%> (+0.47%) ⬆️
pkg/services/rpcsrv/server.go 77.41% <100.00%> (+0.04%) ⬆️
pkg/rpcclient/actor/waiter.go 65.81% <0.00%> (ø)
pkg/network/tcp_transport.go 68.42% <0.00%> (+8.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov merged commit 3ac76c3 into master Nov 23, 2022
@roman-khimov roman-khimov deleted the improve-wsclient-handshake-error branch November 23, 2022 11:40
@roman-khimov roman-khimov modified the milestones: v0.100.0, v0.99.7 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants