State-changing methods in RPC wrappers #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same rationale as for BaseWriter or nep17.TokenWriter, otherwise it's hard to build on top of plain Divisible structure.
Codecov Report
@@ Coverage Diff @@
## master #2778 +/- ##
==========================================
- Coverage 84.93% 84.85% -0.09%
==========================================
Files 327 327
Lines 40781 40814 +33
==========================================
- Hits 34637 34632 -5
- Misses 4747 4787 +40
+ Partials 1397 1395 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
reviewed
Nov 8, 2022
It's a common pattern.
* strip NEP-XX methods before going into generator to avoid unused imports * nepXX.Invoker types already include Call * always import util, it's used for Hash
"verify" contract doesn't have any safe methods.
They make no sense there.
roman-khimov
force-pushed
the
rpc-wrapper-writer
branch
from
e24a62d to
69d8905
Compare
AnnaShaleva
approved these changes
Nov 8, 2022
fyrchik
approved these changes
Nov 8, 2022
| } | ||
|
|
||
| // Actor is used by Contract to call state-changing methods. | ||
| type Actor interface { | ||
| Invoker | ||
| nep11.Actor | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.