Shutdown sequence fixes #2652
Merged
Shutdown sequence fixes #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It never runs the server, so 746644a was a bit wrong with this.
roman-khimov
force-pushed
the
shutdown-fixes
branch
from
964cd48 to
0f80482
Compare
Unsubscribe and drain first, then return from the Shutdown method. It's important wrt to subsequent chain shutdown process (normally it's closed right after the network server).
Blockchain's notificationDispatcher sends events to channels and these channels must be read from. Unfortunately, regular service shutdown procedure does unsubscription first (outside of the read loop) and only then drains the channel. While it waits for unsubscription request to be accepted notificationDispatcher can try pushing more data into the same channel which will lead to a deadlock. Reading in the same method solves this, any number of events can be pushed until unsub channel accepts the data.
And synchronize other threads with channels instead of mutexes. Overall this scheme is more reliable.
roman-khimov
force-pushed
the
shutdown-fixes
branch
from
0f80482 to
779a5c0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 85.13% 85.04% -0.09%
==========================================
Files 315 315
Lines 38841 38866 +25
==========================================
- Hits 33067 33054 -13
- Misses 4418 4458 +40
+ Partials 1356 1354 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests failed on me.