Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Filter version tags for version calculation #2641

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Makefile: Filter version tags for version calculation #2641

merged 1 commit into from
Aug 18, 2022

Conversation

anikeev-yadro
Copy link
Contributor

@anikeev-yadro anikeev-yadro commented Aug 11, 2022

Summary:
only tags that start with "v" will be accounted for in VERSION calculation.

Motivation:
this allows us to use any custom tags along with tags that denote releases

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #2641 (7340a06) into master (509cdec) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2641      +/-   ##
==========================================
- Coverage   84.91%   84.88%   -0.03%     
==========================================
  Files         304      311       +7     
  Lines       38370    38556     +186     
==========================================
+ Hits        32580    32729     +149     
- Misses       4409     4452      +43     
+ Partials     1381     1375       -6     
Impacted Files Coverage Δ
pkg/rpcclient/nep17.go 44.15% <0.00%> (-24.68%) ⬇️
pkg/services/oracle/oracle.go 72.79% <0.00%> (-14.71%) ⬇️
pkg/services/oracle/request.go 57.99% <0.00%> (-5.03%) ⬇️
pkg/core/transaction/transaction.go 85.18% <0.00%> (-1.49%) ⬇️
pkg/rpcclient/rpc.go 79.41% <0.00%> (-0.39%) ⬇️
cli/wallet/nep17.go 71.26% <0.00%> (-0.30%) ⬇️
cli/wallet/wallet.go 84.41% <0.00%> (-0.30%) ⬇️
pkg/compiler/codegen.go 92.22% <0.00%> (-0.15%) ⬇️
pkg/rpcclient/native.go 56.17% <0.00%> (ø)
pkg/rpcclient/policy.go 65.38% <0.00%> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this makes sense, please take a look at the commit history in this repository and reformat the commit message appropriately. It should be something like Makefile: filter ... and it'd be nice to add a note on why do need this.

This allows us to use any custom tags along with tags that denote releases.

Signed-off-by: anikeev-yadro <[email protected]>
@anikeev-yadro
Copy link
Contributor Author

reformated. Please review.

@roman-khimov roman-khimov added this to the v0.99.3 milestone Aug 18, 2022
@roman-khimov roman-khimov merged commit c056c64 into nspcc-dev:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants