Move code generation from rpcclient to smartcontract #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPC client shouldn't build scripts and this function can be useful as a reusable building block.
Move the last remaining script-related things out of the rpcclient.
roman-khimov
force-pushed
the
sc-code-emit
branch
from
852f619 to
1fa3a00
Compare
Codecov Report
@@ Coverage Diff @@
## master #2610 +/- ##
==========================================
+ Coverage 84.52% 84.59% +0.07%
==========================================
Files 297 299 +2
Lines 37865 37882 +17
==========================================
+ Hits 32005 32048 +43
+ Misses 4454 4424 -30
- Partials 1406 1410 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. |
fyrchik
approved these changes
Jul 26, 2022
cli/wallet/validator.go
Outdated
| res, err := c.SignAndPushInvocationTx(w.Bytes(), acc, sysGas, gas, []rpcclient.SignerAccount{{ | ||
| script, err := smartcontract.CreateCallWithAssertScript(neoContractHash, method, acc.PrivateKey().PublicKey().Bytes()) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Yeah, I've noticed this also, but for some reason thought that it's an internal function the result of which is wrapped outside if needed. But that's not the case, so NewExitError is appropriate here. Fixed.
It wasn't possible way back when this test was written (CreateOracleResponseScript was a method), now we can simplify things.
roman-khimov
force-pushed
the
sc-code-emit
branch
from
f779241 to
c8ff489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving on with #2597.