Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: allow to handle GetMPTData with KeepOnlyLatestState on #2600

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

AnnaShaleva
Copy link
Member

And adjust documentation along the way.

Close #2152.

@AnnaShaleva AnnaShaleva requested a review from roman-khimov July 14, 2022 11:34
@AnnaShaleva
Copy link
Member Author

AnnaShaleva commented Jul 14, 2022

@roman-khimov, finally, I found out what was wrong with the updated test. State exchange is impossible if the source node is light-weighted and has GC off, so I've used invalid configuration. I've added a note about it to our docs.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2600 (e46ec97) into master (125c280) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
+ Coverage   84.58%   84.60%   +0.02%     
==========================================
  Files         298      298              
  Lines       37836    37858      +22     
==========================================
+ Hits        32003    32030      +27     
+ Misses       4424     4419       -5     
  Partials     1409     1409              
Impacted Files Coverage Δ
pkg/network/server.go 73.99% <ø> (-0.01%) ⬇️
pkg/config/protocol_config.go 85.54% <100.00%> (ø)
pkg/core/transaction/transaction.go 85.18% <0.00%> (-1.49%) ⬇️
pkg/compiler/codegen.go 92.36% <0.00%> (-0.11%) ⬇️
pkg/core/native/management.go 92.30% <0.00%> (-0.10%) ⬇️
pkg/compiler/inline.go 96.75% <0.00%> (+0.07%) ⬆️
pkg/core/dao/dao.go 80.26% <0.00%> (+0.16%) ⬆️
pkg/core/blockchain.go 82.33% <0.00%> (+0.17%) ⬆️
pkg/consensus/consensus.go 73.36% <0.00%> (+0.43%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a559e...e46ec97. Read the comment docs.

@roman-khimov roman-khimov merged commit ed53fd3 into master Jul 15, 2022
@roman-khimov roman-khimov deleted the handle-mptdata branch July 15, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network: allow to handle GetMPTData command if KeepOnlyLatestState enabled
2 participants