Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: check methods offsets while contract deploying #2538

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

AnnaShaleva
Copy link
Member

Close #2534 and port neo-project/neo-vm#476.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2538 (1005c1f) into master (b6829f3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2538      +/-   ##
==========================================
- Coverage   84.95%   84.95%   -0.01%     
==========================================
  Files         295      295              
  Lines       37144    37145       +1     
==========================================
  Hits        31556    31556              
- Misses       4246     4247       +1     
  Partials     1342     1342              
Impacted Files Coverage Δ
pkg/core/interop/context.go 92.14% <100.00%> (ø)
pkg/core/native/management.go 92.39% <100.00%> (+0.01%) ⬆️
pkg/core/native/native_neo.go 81.79% <100.00%> (ø)
pkg/vm/context.go 88.12% <100.00%> (ø)
pkg/core/transaction/signer.go 75.00% <0.00%> (-12.50%) ⬇️
pkg/network/capability/capability.go 69.23% <0.00%> (-5.77%) ⬇️
pkg/network/message.go 94.02% <0.00%> (-2.24%) ⬇️
pkg/network/server.go 74.20% <0.00%> (+0.09%) ⬆️
pkg/network/tcp_transport.go 68.42% <0.00%> (+8.77%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c8d62...1005c1f. Read the comment docs.

@AnnaShaleva AnnaShaleva force-pushed the restrict-out-of-bounds branch from d8299d3 to 389c164 Compare June 6, 2022 09:17
@AnnaShaleva AnnaShaleva force-pushed the restrict-out-of-bounds branch from 389c164 to 1005c1f Compare June 6, 2022 09:18
@roman-khimov roman-khimov merged commit 926b082 into master Jul 4, 2022
@roman-khimov roman-khimov deleted the restrict-out-of-bounds branch July 4, 2022 09:54
roman-khimov added a commit that referenced this pull request Jul 28, 2022
This reverts commit bd5644a restoring changes
from #2538.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore out of bounds method check
2 participants