Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: alias build target as bin #2537

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Makefile: alias build target as bin #2537

merged 1 commit into from
Jun 6, 2022

Conversation

AnnaShaleva
Copy link
Member

Close #2529.

@AnnaShaleva
Copy link
Member Author

We have a lot of make build dependencies: inside Dockerfile, GA files, neo-bench, neo-go-sc-wrkshop. Also. the users of neo-go could get used to make build. Do we need to completely remove make build?

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2537 (cd6c6aa) into master (b6829f3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head cd6c6aa differs from pull request most recent head e8d71eb. Consider uploading reports for the commit e8d71eb to get more accurate results

@@            Coverage Diff             @@
##           master    #2537      +/-   ##
==========================================
+ Coverage   84.95%   85.01%   +0.05%     
==========================================
  Files         295      295              
  Lines       37144    37144              
==========================================
+ Hits        31556    31577      +21     
+ Misses       4246     4220      -26     
- Partials     1342     1347       +5     
Impacted Files Coverage Δ
pkg/core/interop/context.go 92.14% <100.00%> (ø)
pkg/core/native/management.go 92.38% <100.00%> (ø)
pkg/core/native/native_neo.go 81.79% <100.00%> (ø)
pkg/core/transaction/signer.go 75.00% <0.00%> (-12.50%) ⬇️
pkg/network/capability/capability.go 69.23% <0.00%> (-5.77%) ⬇️
pkg/network/message.go 94.02% <0.00%> (-2.24%) ⬇️
pkg/services/notary/notary.go 84.69% <0.00%> (-0.98%) ⬇️
pkg/services/oracle/request.go 63.01% <0.00%> (+5.02%) ⬆️
pkg/network/compress.go 76.00% <0.00%> (+12.00%) ⬆️
pkg/services/oracle/oracle.go 88.37% <0.00%> (+15.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c8d62...e8d71eb. Read the comment docs.

@roman-khimov
Copy link
Member

Do we need to completely remove make build?

No, why would we do that?

@AnnaShaleva
Copy link
Member Author

No, why would we do that?

Just clarifying the task, OK.

@AnnaShaleva AnnaShaleva requested a review from roman-khimov June 6, 2022 08:59
@roman-khimov roman-khimov merged commit c6ced9b into master Jun 6, 2022
@roman-khimov roman-khimov deleted the add-bin-target branch June 6, 2022 09:00
@realloc
Copy link

realloc commented Jun 6, 2022

Actually, that's not what we asked for =) bin here means the name of the binary, i.e. make neo-go.

AnnaShaleva added a commit that referenced this pull request Jun 6, 2022
AnnaShaleva added a commit that referenced this pull request Jun 7, 2022
AnnaShaleva added a commit that referenced this pull request Jun 7, 2022
AnnaShaleva added a commit that referenced this pull request Jun 7, 2022
AnnaShaleva added a commit that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synchronize common make targets across all projects
3 participants