Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: upgrade yaml package from v2 to v3 #2527

Merged
merged 1 commit into from
May 30, 2022
Merged

gomod: upgrade yaml package from v2 to v3 #2527

merged 1 commit into from
May 30, 2022

Conversation

AnnaShaleva
Copy link
Member

Close #2085.

@AnnaShaleva
Copy link
Member Author

AnnaShaleva commented May 30, 2022

Indentation issue is still there, but closed unmerged due to the lack of activity. We can create our own fork with fix, but I'm not sure whether we need one more dependant fork. The issue is not critical, IMO.

Close #2085.

Signed-off-by: Evgeniy Stratonikov <[email protected]>
@roman-khimov
Copy link
Member

we need one more dependant fork

No. We use it for various configuration files, if they're compatible with v3 we're fine.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #2527 (ec21c14) into master (e8a876a) will increase coverage by 0.09%.
The diff coverage is 95.52%.

@@            Coverage Diff             @@
##           master    #2527      +/-   ##
==========================================
+ Coverage   85.03%   85.12%   +0.09%     
==========================================
  Files         294      294              
  Lines       37028    37078      +50     
==========================================
+ Hits        31485    31563      +78     
+ Misses       4223     4190      -33     
- Partials     1320     1325       +5     
Impacted Files Coverage Δ
cli/smartcontract/generate.go 83.33% <ø> (ø)
cli/smartcontract/smart_contract.go 92.53% <ø> (ø)
pkg/compiler/compiler.go 74.60% <ø> (ø)
pkg/config/config.go 82.35% <ø> (ø)
cli/smartcontract/permission.go 91.20% <81.25%> (-3.11%) ⬇️
pkg/core/native/native_neo.go 81.81% <100.00%> (+1.46%) ⬆️
pkg/network/compress.go 64.00% <0.00%> (-12.00%) ⬇️
pkg/network/message.go 94.02% <0.00%> (-2.24%) ⬇️
pkg/services/oracle/request.go 63.01% <0.00%> (+5.02%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee82e29...ec21c14. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to yaml.v3
3 participants