Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: implement immutable stackitems #2525

Merged
merged 3 commits into from
May 31, 2022
Merged

vm: implement immutable stackitems #2525

merged 3 commits into from
May 31, 2022

Conversation

AnnaShaleva
Copy link
Member

Close #2516.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #2525 (42a051e) into master (a79c80c) will decrease coverage by 0.06%.
The diff coverage is 49.15%.

@@            Coverage Diff             @@
##           master    #2525      +/-   ##
==========================================
- Coverage   85.10%   85.03%   -0.07%     
==========================================
  Files         294      295       +1     
  Lines       37011    37124     +113     
==========================================
+ Hits        31497    31569      +72     
- Misses       4190     4212      +22     
- Partials     1324     1343      +19     
Impacted Files Coverage Δ
pkg/vm/vm.go 93.34% <42.85%> (-0.80%) ⬇️
pkg/vm/stackitem/item.go 88.19% <43.75%> (-2.40%) ⬇️
pkg/core/interop/runtime/engine.go 100.00% <100.00%> (ø)
pkg/core/interop/runtime/util.go 89.02% <100.00%> (-10.98%) ⬇️
pkg/vm/stackitem/immutable.go 100.00% <100.00%> (ø)
cli/smartcontract/permission.go 91.20% <0.00%> (-3.11%) ⬇️
pkg/services/notary/notary.go 84.69% <0.00%> (-0.98%) ⬇️
pkg/rpc/server/server.go 77.42% <0.00%> (-0.05%) ⬇️
pkg/config/hardfork.go 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79c80c...42a051e. Read the comment docs.

Perform add/set/remove operations with VM type firstly, and with
refcounter after that. It is needed to be able to extend add/set/remove
operations with extra checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immutable VM items and removal of DeepCopy
2 participants