Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: emit vote/candidate events #2523

Merged
merged 1 commit into from
May 30, 2022
Merged

native: emit vote/candidate events #2523

merged 1 commit into from
May 30, 2022

Conversation

roman-khimov
Copy link
Member

Follow neo-project/neo#2754.

I'll probably add some tests.

@roman-khimov roman-khimov added this to the v0.99.0 milestone May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2523 (5e01331) into master (c605cfb) will increase coverage by 0.09%.
The diff coverage is 90.64%.

@@            Coverage Diff             @@
##           master    #2523      +/-   ##
==========================================
+ Coverage   85.02%   85.12%   +0.09%     
==========================================
  Files         294      294              
  Lines       37005    37075      +70     
==========================================
+ Hits        31465    31560      +95     
+ Misses       4219     4189      -30     
- Partials     1321     1326       +5     
Impacted Files Coverage Δ
pkg/vm/vm.go 94.14% <62.50%> (-0.40%) ⬇️
pkg/core/interop/contract/call.go 73.38% <80.00%> (+0.38%) ⬆️
pkg/core/blockchain.go 82.31% <100.00%> (ø)
pkg/core/interop/context.go 92.14% <100.00%> (+0.25%) ⬆️
pkg/core/interop/runtime/engine.go 100.00% <100.00%> (ø)
pkg/core/native/designate.go 82.18% <100.00%> (-0.29%) ⬇️
pkg/core/native/management.go 92.41% <100.00%> (-0.09%) ⬇️
pkg/core/native/native_neo.go 81.81% <100.00%> (+1.46%) ⬆️
pkg/core/native/native_nep17.go 87.20% <100.00%> (-0.26%) ⬇️
pkg/core/native/oracle.go 72.19% <100.00%> (-0.54%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502cdd6...5e01331. Read the comment docs.

pkg/core/native/native_neo.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov marked this pull request as ready for review May 28, 2022 15:44
@roman-khimov roman-khimov requested a review from AnnaShaleva May 28, 2022 15:44
@roman-khimov roman-khimov merged commit ee82e29 into master May 30, 2022
@roman-khimov roman-khimov deleted the add-vote-events branch May 30, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants