Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: adjust System.Runtime.GetRandom #2519

Merged
merged 2 commits into from
May 26, 2022
Merged

core: adjust System.Runtime.GetRandom #2519

merged 2 commits into from
May 26, 2022

Conversation

AnnaShaleva
Copy link
Member

Close #2518.

1. Make seed dependant on the GetRandom invocations counter.
2. Adjust syscall price.
Fantastic Beasts and Where to Find Them
@AnnaShaleva AnnaShaleva marked this pull request as ready for review May 26, 2022 11:21
@AnnaShaleva AnnaShaleva changed the title core: adjuxt System.Runtime.GetRandom core: adjust System.Runtime.GetRandom May 26, 2022
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #2519 (8055952) into master (a3285ea) will decrease coverage by 0.02%.
The diff coverage is 76.31%.

@@            Coverage Diff             @@
##           master    #2519      +/-   ##
==========================================
- Coverage   85.13%   85.10%   -0.03%     
==========================================
  Files         294      294              
  Lines       36988    37005      +17     
==========================================
+ Hits        31490    31494       +4     
- Misses       4179     4187       +8     
- Partials     1319     1324       +5     
Impacted Files Coverage Δ
pkg/config/hardfork_string.go 50.00% <ø> (ø)
pkg/core/interop/context.go 91.89% <ø> (ø)
pkg/core/interops.go 100.00% <ø> (ø)
pkg/core/interop/runtime/util.go 89.02% <52.63%> (-10.98%) ⬇️
pkg/config/hardfork.go 100.00% <100.00%> (ø)
pkg/core/interop_system.go 92.06% <100.00%> (ø)
pkg/rpc/response/result/invoke.go 82.44% <100.00%> (ø)
pkg/core/transaction/transaction.go 84.55% <0.00%> (-1.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6666c5...8055952. Read the comment docs.

@roman-khimov roman-khimov merged commit 0111cd8 into master May 26, 2022
@roman-khimov roman-khimov deleted the fix-getrand branch May 26, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetRandom fixes and hardfork rename
2 participants