Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/server: don't spit out error if notary request already exists #2426

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

roman-khimov
Copy link
Member

It could be sent by another actor and that's OK.

Although signatures from this request should still be processed.

@roman-khimov roman-khimov added this to the v0.99.0 milestone Apr 5, 2022
It could be sent by another actor and that's OK.
@roman-khimov roman-khimov force-pushed the notary-ignore-erralreadyexists branch from 1fa7f7c to 2c16e04 Compare April 5, 2022 14:37
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #2426 (2c16e04) into master (c12a3b7) will decrease coverage by 0.02%.
The diff coverage is 91.91%.

@@            Coverage Diff             @@
##           master    #2426      +/-   ##
==========================================
- Coverage   85.14%   85.11%   -0.03%     
==========================================
  Files         290      289       -1     
  Lines       36139    36035     -104     
==========================================
- Hits        30770    30672      -98     
+ Misses       4088     4082       -6     
  Partials     1281     1281              
Impacted Files Coverage Δ
cli/server/server.go 79.78% <0.00%> (-0.17%) ⬇️
cli/smartcontract/generate.go 83.33% <ø> (ø)
pkg/core/blockchain.go 83.02% <50.00%> (ø)
pkg/core/native/oracle.go 72.19% <71.42%> (ø)
pkg/neotest/basic.go 94.09% <92.00%> (ø)
pkg/neotest/client.go 90.00% <92.30%> (ø)
pkg/core/native/interop.go 63.23% <100.00%> (ø)
pkg/core/native/management.go 92.92% <100.00%> (ø)
pkg/neotest/chain/chain.go 94.39% <100.00%> (ø)
pkg/neotest/compile.go 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c0e2f...2c16e04. Read the comment docs.

@roman-khimov roman-khimov merged commit 0c3327a into master Apr 5, 2022
@roman-khimov roman-khimov deleted the notary-ignore-erralreadyexists branch April 5, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants