Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for calculatenetworkfee RPC handler for custom witnesses #3447

Open
AnnaShaleva opened this issue May 17, 2024 · 0 comments
Open

Add a test for calculatenetworkfee RPC handler for custom witnesses #3447

AnnaShaleva opened this issue May 17, 2024 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes S4 Routine test Unit tests U3 Regular
Milestone
v0.110.0

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented May 17, 2024 •
edited
Loading

We need a properly constructed test for calculatenetworkfee RPC handler for custom Koblitz-based transaction witnesses. We also need to ensure that fee calculated by this test match precisely the expected value. This test should not use some static transaction blob since it'll be hard to keep it up-to-date. We also need to enable Cockatrice for our testchains to make this test pass.
@AnnaShaleva AnnaShaleva added I3 Minimal impact test Unit tests U4 Nothing urgent S4 Routine labels May 17, 2024
@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone May 17, 2024
AnnaShaleva added a commit that referenced this issue May 17, 2024
@AnnaShaleva
rpcsrv: remove test for Koblitz-based witness verification
ce442a1 
It will be built properly in #3447.

Signed-off-by: Anna Shaleva <[email protected]>
@roman-khimov roman-khimov added enhancement Improving existing functionality U3 Regular I4 No visible changes and removed I3 Minimal impact U4 Nothing urgent labels May 17, 2024
@AnnaShaleva AnnaShaleva modified the milestones: v0.107.2, v0.108.0 Dec 13, 2024
@roman-khimov roman-khimov modified the milestones: v0.108.0, v0.110.0 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I4 No visible changes S4 Routine test Unit tests U3 Regular
Projects
None yet
Milestone
v0.110.0
Development

No branches or pull requests
2 participants
@roman-khimov @AnnaShaleva