Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting to set ExecFeeFactor or StoragePrice to 0 gives inaccurate error message #3311

Closed
EdgeDLT opened this issue Feb 11, 2024 · 0 comments · Fixed by #3406
Closed

Attempting to set ExecFeeFactor or StoragePrice to 0 gives inaccurate error message #3311

EdgeDLT opened this issue Feb 11, 2024 · 0 comments · Fixed by #3406
Labels
bug Something isn't working I4 No visible changes S4 Routine U3 Regular
Milestone
v0.106.0

Comments

@EdgeDLT
Copy link
Contributor

EdgeDLT commented Feb 11, 2024

Current Behavior

Using CommitteeInvoker in neotest to set fee policies. When testing with 0 as input for ExecFeeFactor and StoragePrice, it gives the error:

at instruction 50 (SYSCALL): ExecFeeFactor must be between 0 and 100

...

at instruction 64 (SYSCALL): StoragePrice must be between 0 and 10000000

Expected Behavior

Error message should suggest an input between 1 and 100 for ExecFeeFactor and 1 or 10000000 for StoragePrice.

Fee per byte is happy with zero, I assume that is intended.

Context

Testing the influence of fee adjustments on common transaction types. Encountered this issue while making test cases.

Your Environment

Windows 10
go v1.22.0
neo-go v0.105.1
@EdgeDLT EdgeDLT added bug Something isn't working U2 Seriously planned labels Feb 11, 2024
@roman-khimov roman-khimov added this to the v0.106.0 milestone Feb 11, 2024
@roman-khimov roman-khimov added U3 Regular S4 Routine I4 No visible changes and removed U2 Seriously planned labels Feb 11, 2024
AliceInHunterland added a commit that referenced this issue Apr 9, 2024
@AliceInHunterland
native: adjust error message for ExecFeeFactor and StoragePrice
fcbfc3b 
Close #3311

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland mentioned this issue Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging a pull request may close this issue.

native: adjust error message for ExecFeeFactor and StoragePrice nspcc-dev/neo-go
2 participants
@EdgeDLT @roman-khimov