Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing TestGetConfigFromContext on Windows #3305

Closed
AnnaShaleva opened this issue Feb 6, 2024 · 0 comments · Fixed by #3306
Closed

Failing TestGetConfigFromContext on Windows #3305

AnnaShaleva opened this issue Feb 6, 2024 · 0 comments · Fixed by #3306
Assignees
@AliceInHunterland
Labels
bug Something isn't working I4 No visible changes S4 Routine test Unit tests U2 Seriously planned
Milestone
v0.106.0

Comments

@AnnaShaleva
Copy link
Member

Path-related issue introduced in #3206.

2024-02-06T09:12:48.5112738Z === RUN   TestGetConfigFromContext/relative-path
2024-02-06T09:12:48.5113506Z     server_test.go:60: 
2024-02-06T09:12:48.5114548Z         	Error Trace:	D:/a/neo-go/neo-go/cli/server/server_test.go:60
2024-02-06T09:12:48.5115419Z         	Error:      	Not equal: 
2024-02-06T09:12:48.5116507Z         	            	expected: "../../config/chains/testnet"
2024-02-06T09:12:48.5134020Z         	            	actual  : "..\\..\\config\\chains\\testnet"
2024-02-06T09:12:48.5134736Z         	            	
2024-02-06T09:12:48.5135258Z         	            	Diff:
2024-02-06T09:12:48.5135970Z         	            	--- Expected
2024-02-06T09:12:48.5136619Z         	            	+++ Actual
2024-02-06T09:12:48.5137312Z         	            	@@ -1 +1 @@
2024-02-06T09:12:48.5138197Z         	            	-../../config/chains/testnet
2024-02-06T09:12:48.5139081Z         	            	+..\..\config\chains\testnet
2024-02-06T09:12:48.5140004Z         	Test:       	TestGetConfigFromContext/relative-path
2024-02-06T09:12:48.5140787Z --- FAIL: TestGetConfigFromContext (0.01s)
2024-02-06T09:12:48.5141644Z     --- PASS: TestGetConfigFromContext/config-path (0.01s)
2024-02-06T09:12:48.5142686Z     --- PASS: TestGetConfigFromContext/config-file (0.00s)
2024-02-06T09:12:48.5143639Z     --- FAIL: TestGetConfigFromContext/relative-path (0.00s)
@AnnaShaleva AnnaShaleva added bug Something isn't working test Unit tests U2 Seriously planned S4 Routine I4 No visible changes labels Feb 6, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.0 milestone Feb 6, 2024
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
b00b06f 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
a64fd5d 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
b0ef6f2 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
ef032bb 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
571f2a3 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
62983f7 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
6c38954 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
2fbde0b 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
2954612 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
630d56b 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
78973e2 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
e06262f 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
e881f84 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
d523ab4 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 7, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
86219e9 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland mentioned this issue Feb 7, 2024
Merged
AliceInHunterland added a commit that referenced this issue Feb 8, 2024
@AliceInHunterland
test: fix TestGetConfigFromContext on Windows
0e54978 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 9, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
2e5da30 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 9, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
b07bfb0 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 9, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
5267363 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 9, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
6ffdb1a 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 9, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
5d5a395 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 9, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
ceadf3c 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 9, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
c80f42a 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Feb 12, 2024
@AliceInHunterland
config: fix TestGetConfigFromContext on Windows
939631c 
Failing test caused by hardcoded relative path check which is different
for Windows.

Close #3305

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
bug Something isn't working I4 No visible changes S4 Routine test Unit tests U2 Seriously planned
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging a pull request may close this issue.

config: fix TestGetConfigFromContext on Windows nspcc-dev/neo-go
2 participants
@AnnaShaleva @AliceInHunterland