Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NNS wrapper update #2732

Closed
roman-khimov opened this issue Oct 7, 2022 · 0 comments · Fixed by #3291
Closed

NNS wrapper update #2732

roman-khimov opened this issue Oct 7, 2022 · 0 comments · Fixed by #3291
Assignees
@AliceInHunterland
Labels
enhancement Improving existing functionality I2 Regular impact rpc RPC server and client S4 Routine U3 Regular
Milestone
v0.106.0

Comments

@roman-khimov
Copy link
Member

We have an official NNS deployed to mainnet now which means that it has a stable API and we can provide a wrapper for it. One thing I don't like about it is that it's a non-native contract and keeping this wrapper in the pkg/rpcclient seems to be inappropriate. At the same time it'll be build on top of rpcclient and we'll need it at least in the wallet code. Maybe some new top-level directory is needed for it, we can have more of these wrappers. Or a separate repository, but that'd make a circular dependency which is not a good thing.
@roman-khimov roman-khimov added the rpc RPC server and client label Oct 7, 2022
@roman-khimov roman-khimov added this to the v0.99.6 milestone Oct 7, 2022
This was referenced Oct 7, 2022
Open
Open
@roman-khimov roman-khimov modified the milestones: v0.100.0, v0.100.1 Nov 25, 2022
@AnnaShaleva AnnaShaleva mentioned this issue Dec 1, 2022
Open
@roman-khimov roman-khimov modified the milestones: v0.100.1, v0.100.2, v0.100.3 Dec 28, 2022
@roman-khimov roman-khimov modified the milestones: v0.101.1, v0.103.0 Feb 17, 2023
@AnnaShaleva AnnaShaleva modified the milestones: v0.104.0, v0.105.0 Nov 9, 2023
@roman-khimov roman-khimov added I2 Regular impact U3 Regular S4 Routine feature Completely new functionality enhancement Improving existing functionality and removed feature Completely new functionality labels Dec 21, 2023
@roman-khimov roman-khimov modified the milestones: v0.105.0, v0.106.0 Dec 21, 2023
AliceInHunterland added a commit that referenced this issue Jan 16, 2024
@AliceInHunterland
smartcontract: update nns wrapper
e13ec42 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 16, 2024
@AliceInHunterland
smartcontract: update nns wrapper
c591a27 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 16, 2024
@AliceInHunterland
smartcontract: update nns wrapper
37ada47 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 16, 2024
@AliceInHunterland
smartcontract: update nns wrapper
9e23ed4 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AliceInHunterland AliceInHunterland mentioned this issue Jan 16, 2024
Merged
AliceInHunterland added a commit that referenced this issue Jan 23, 2024
@AliceInHunterland
smartcontract: update nns wrapper
34bf19a 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 23, 2024
@AliceInHunterland
smartcontract: update nns wrapper
e7f7ce6 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 23, 2024
@AliceInHunterland
smartcontract: update nns wrapper
4ae4432 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 24, 2024
@AliceInHunterland
smartcontract: update nns wrapper
88cdf47 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 25, 2024
@AliceInHunterland
smartcontract: update nns wrapper
8912962 
Added missing function from smart-contract manifest.

Refs #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 26, 2024
@AliceInHunterland
smartcontract: update nns wrapper
c19bbd0 
Added missing function from smart-contract manifest.

Close #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 26, 2024
@AliceInHunterland
smartcontract: update nns wrapper
1a693d0 
Added missing function from smart-contract manifest.

Close #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 26, 2024
@AliceInHunterland
smartcontract: update nns wrapper
000109b 
Added missing function from smart-contract manifest.

Close #2732

Signed-off-by: Ekaterina Pavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
enhancement Improving existing functionality I2 Regular impact rpc RPC server and client S4 Routine U3 Regular
Projects
None yet
Milestone
v0.106.0
Development

Successfully merging a pull request may close this issue.

smartcontract: update nns wrapper nspcc-dev/neo-go
3 participants
@roman-khimov @AnnaShaleva @AliceInHunterland