-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: C# RocksDBStore, bench concurrent HTTP connections, Go monitoring and others #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested changes
Aug 28, 2020
AnnaShaleva
force-pushed
the
sharp-rocks-db-store
branch
6 times, most recently
from
September 1, 2020 15:09
c14b469
to
7b83ce1
Compare
AnnaShaleva
force-pushed
the
sharp-rocks-db-store
branch
from
September 1, 2020 15:12
7b83ce1
to
f7278fb
Compare
AnnaShaleva
force-pushed
the
sharp-rocks-db-store
branch
from
September 2, 2020 12:13
5f9d9af
to
1d3cd00
Compare
Release version of RocksDBStore does not work properly, that's why we have to build it from source. It also requires librocksdb-dev. See neo-project/neo-modules#330
Supposed to close #22, but C# node still have issues with passing 100-workers test and it's a C# RPC problem.
`RATE` mode assumes that all requests are being sent from the single HTTP connection. `WORKER` mode assumes that the number of connections is equal to the number of workers. Part of #23
Closes #23 Worker client (txSender) is responsible for transactions sending only. Sirvice client (blockRequester) should do the rest of work, e.g. fetching and parsing blocks. There's a reason for that: In `RATE` mode RPCClient should perform all requests via single HTTP connection. If RPCClient use the single client for both transactions sending and blocks parsing, test will end very soon due to "no free connections available to host" fasthttp error during blocks parsing. In order to avoid this error, we should use another HTTP connection for service requests. That's possible only with using another fasthttp client.
It is more useful to count RPC error rate as the number of errors devided by the whole number of queries (not the successful ones only).
Init 1 worker with appropriate delay for RATE mode to send transactions synchronously
Previous commits make it possible for C# 4-nodes network and for C# single-node to pass RATE mode tests.
AnnaShaleva
force-pushed
the
sharp-rocks-db-store
branch
from
September 2, 2020 16:02
1d3cd00
to
3e88fcb
Compare
roman-khimov
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of small but important fixes.