Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAStackViewDistributionFillProportionally implemented #8

Conversation

bartvandendriessche
Copy link
Contributor

Did a quick draft implementation for the FillProportionally distribution.

Also updated the Example project so that:

  • Distribution strategies can be switched
  • Buttons have different intrinsicContentSize

@nsomar
Copy link
Owner

nsomar commented Jun 18, 2015

Hello, super cool addition 👍
Are you planning on adding some test coverage for these distribution? If not, then I might add coverage and merge it over the weekend.

@bartvandendriessche
Copy link
Contributor Author

Heya, not sure if I'll have time over the weekend to add tests.

If I do, I'll try to add some tests. If you've already added them by then, I might try to fill in some other feature, so by all means, don't wait for me :)

@bartvandendriessche
Copy link
Contributor Author

Quick side note, the tests check that the proportional view is within a range of 1 point of the 'calculated reference value', because AutoLayout tries prevent misaligned views (i.e. it will round).

@nsomar
Copy link
Owner

nsomar commented Jun 21, 2015

Wonderfull addition 👍 merging right away :)

nsomar added a commit that referenced this pull request Jun 21, 2015
…nStrategyFillProportionally

OAStackViewDistributionFillProportionally implemented
@nsomar nsomar merged commit 592acb7 into nsomar:master Jun 21, 2015
@bartvandendriessche bartvandendriessche deleted the OAStackViewDistributionStrategyFillProportionally branch June 21, 2015 14:12
@nsomar nsomar mentioned this pull request Jun 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants