Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set cpu and memory reservations #137

Merged
merged 5 commits into from
Jul 14, 2015

Conversation

edmcman
Copy link

@edmcman edmcman commented Jul 8, 2015

Add the ability to set reservations from Vagrant.

@edmcman
Copy link
Author

edmcman commented Jul 9, 2015

Do you have any advice on how to refactor this so it doesn't cause robocop warnings? The changes I make are tiny, but happen to push several complexity indicators over their limits.

@michaeljb
Copy link
Contributor

Well we don't have much actually set in .rubocop.yml; the complexity settings are all in .rubocop_todo.yml. It would take some serious refactoring to get the whole project down to RuboCop's defaults, and I agree that your changes here are pretty tiny (and match the style of the changed files).

I think it'd be fine if you just regenerate the todo file and include it in this PR.

@edmcman
Copy link
Author

edmcman commented Jul 9, 2015

Ok, will do!

@edmcman
Copy link
Author

edmcman commented Jul 9, 2015

Finally passing :)

@michaeljb
Copy link
Contributor

Looks good, thanks @edmcman!

michaeljb added a commit that referenced this pull request Jul 14, 2015
Add ability to set cpu and memory reservations
@michaeljb michaeljb merged commit 8670fea into nsidc:master Jul 14, 2015
michaeljb added a commit that referenced this pull request Jul 14, 2015
@edmcman edmcman deleted the resource_limit branch September 1, 2015 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants