Added public_address provider capability
#130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've fixed warnings related to my code, but all other errors need to be fixed outside of this PR. |
|
Is something wrong with my code, if it didn't get into a release? |
|
I'm not sure what happened actually... After I updated the RuboCop config and made sure Travis wouldn't grab a newer version of it again (4895835), I re-ran each of the Pull Request builds. I was sure this one was still marked as failing, but then I re-ran them all again after the release and now it's passing. I'll be putting together another release today. Sorry for any confusion. Thanks for the contribution! |
michaeljb
added a commit
that referenced
this pull request
Jul 9, 2015
Added `public_address` provider capability
michaeljb
added a commit
that referenced
this pull request
Jul 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes nothing in current plugin logic, but adds a new method to access IP address of running VM from other plugins, for example https://github.com/mkuzmin/vagrant-guestip/blob/master/lib/command.rb#L10
The code is copied from Vagrant core: https://github.com/mitchellh/vagrant/blob/master/plugins/providers/hyperv/cap/public_address.rb