Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xarray.Datatree() guidance for ICESat-2 ATL06 tutorial #92

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Conversation

asteiker
Copy link
Member

xarray.Datatree() is now presented in our ATL06 tutorial to demonstrate the ability to open an entire ICESat-2 granule in xarray without having to specify an individual group. There is the need to specify setting phony dims due to insufficient dimension metadata in some of the ancillary groups, however. I utilized the guidance in @andypbarrett 's SMAP PR (#91) for this.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Feb 12, 2025

Binder 👈 Launch a binder notebook on this branch for commit 8a359ba

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 140fd0e

Binder 👈 Launch a binder notebook on this branch for commit 25e9b28

Updated learning objective to include xarray.DataTree
@mikala-nsidc
Copy link
Collaborator

Hi @asteiker !

I'm hoping we can clarify these few sentences a bit more:

Data could be read into numpy arrays or a pandas.Dataframe. However, each granule would have to be read using a package that reads HDF5 granules such as h5py. xarray does this all under-the-hood in a single line.

Maybe something like:

Reading the data into numpy arrays or a pandas.Dataframe could be an alternative method to using xarray.Datatree(). However, each granule (file) would have to be read first using a package that reads HDF5 files such as h5py. xarray does this all under-the-hood in a single line.

@asteiker
Copy link
Member Author

@mikala-nsidc Updated per your suggestion. Please approve once you are ready.

@asteiker asteiker merged commit f14334c into main Feb 17, 2025
4 checks passed
@asteiker
Copy link
Member Author

@mikala-nsidc I went ahead and merged to align with the datatree article deadline but we can always iterate if you have any other suggestions!

@asteiker asteiker deleted the datatree branch February 17, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants