fix #559 for matplotlib >= 3.6
#602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this is good, but in light of matplotlib/matplotlib@1936c94 maybe we should just inline the old definition (so that we don't emit things like |
|
I tried to keep the change minimal. Getting rid of the Matplotlib function might be a good idea, but I think it's something the maintainer needs to be interested in so it actually gets merged. I also lack some knowledge for this. I rarely use tikzplotlib at the moment and created this fix when I needed it last year. But as a sporadic user and seeing that the repo isn't maintained, I'm not interested in pursuing this much further. |
JasonGross
added a commit
to JasonGross/tikzplotlib
that referenced
this pull request
Apr 12, 2024
Work around matplotlib/matplotlib@1936c94 Fixes nschloe#559 Closes nschloe#602 Closes nschloe#597 Overalps a bit with nschloe#540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
_common_texificationdeprecated byMatplotlib 3.6with_tex_escape. I also changed the name intikzplotlibaccordingly.This should fix #559.