Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): ignore experimental packages during migrating to v14 #9972

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

puku0x
Copy link
Contributor

@puku0x puku0x commented Apr 23, 2022

Current Behavior

Migration for v14 updates the version of some experimental packages.

"@storybook/builder-vite": "0.1.30"       β†’ "~6.4.12" 🚫
"@storybook/jest": "0.0.10"               β†’ "~6.4.12" 🚫
"@storybook/react-native": "5.3.25"       β†’ "5.3.25" βœ…
"@storybook/storybook-deployer": "2.8.11" β†’ "2.8.11" βœ…
"@storybook/test-runner": "0.0.7"         β†’ "~6.4.12" 🚫
"@storybook/testing-library": "0.0.11"    β†’ "~6.4.12" 🚫
"@storybook/testing-angular": "0.0.12"    β†’ "~6.4.12" 🚫
"@storybook/testing-react": "1.2.4"       β†’ "~6.4.12" 🚫
"@storybook/testing-vue": "0.0.3"         β†’ "~6.4.12" 🚫
"@storybook/testing-vue3": "0.0.2"        β†’ "~6.4.12" 🚫

Expected Behavior

Migration for v14 should keep their version.

Related Issue(s)

#9380

@nx-cloud
Copy link

nx-cloud bot commented Apr 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 72f1d12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this branch


βœ… Successfully ran 17 targets

Sent with πŸ’Œ from NxCloud.

@vercel
Copy link

vercel bot commented Apr 23, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Apr 23, 2022 at 0:21AM (UTC)

@puku0x puku0x force-pushed the fix-storybook-migration-v14 branch from bec1a59 to 72f1d12 Compare April 23, 2022 12:17
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we might have wanted to write this migration differently...

But thank you for adding these other packages to the exclusions.

LGTM πŸŽ‰

@FrozenPandaz FrozenPandaz merged commit 8c38b86 into nrwl:master Apr 24, 2022
@puku0x puku0x deleted the fix-storybook-migration-v14 branch June 20, 2022 05:16
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants