Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle failed CI workflows in create-nx-workspace #9915

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

meeroslav
Copy link
Contributor

Current Behavior

If any of the CI workflow generation fails during the CNW, the step is still marked as successful

Expected Behavior

User should be informed if any of the CI workflows failed

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Apr 20, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 20, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5ab95ad. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx-cloud record -- yarn depcheck
✅ Successfully ran 12 targets

Sent with 💌 from NxCloud.

@vercel
Copy link

vercel bot commented Apr 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Apr 20, 2022 at 10:16PM (UTC)

@vsavkin vsavkin merged commit ec0f4b4 into nrwl:master Apr 21, 2022
@meeroslav meeroslav deleted the fix/handle-cnw-ci-errors branch November 8, 2022 15:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants