feat(angular): remove unnecessarily generated code for remotes #9844
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/4WKHdJBSwSsJABuhHSU2rLtqpHeR |
| const component = | ||
| tree.read(pathToComponent, 'utf-8').split('templateUrl')[0] + | ||
| `template: '<router-outlet></router-outlet>' | ||
| }) | ||
| export class AppComponent {}`; |
There was a problem hiding this comment.
imho, it would be better if we have the full template for the component here rather than splitting by a property based on what was previously generated. It's a small component, so the template would be small. It should be clearer, and we'd also reduce the potential maintenance associated with relying on a previous generation that could change and that we don't need to rely on. Regardless of a previous generation, we know the content of what we want in this component.
There was a problem hiding this comment.
Very good point. I will add this as an additional cleanup PR
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
We shouldn't generate unnecessary code when generating remote apps