Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): support css prop for emotion #7395

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

puku0x
Copy link
Contributor

@puku0x puku0x commented Oct 16, 2021

Current Behavior

Emotion's css prop does not work because jsxImportSource is not specified in tsconfig.json.

image

Expected Behavior

css prop should work.

Related Issue(s)

https://nrwlcommunity.slack.com/archives/CMFKWPU6Q/p1634219035415500
See #7384 for @nrwl/next.
Fixes #4520
Closes #7050

@vercel
Copy link

vercel bot commented Oct 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/3DyydC7LbUjTGMegBv2WPTLqUf1q
✅ Preview: Canceled

@puku0x puku0x marked this pull request as ready for review October 16, 2021 10:32
@jaysoo jaysoo merged commit d4f8ba2 into nrwl:master Oct 18, 2021
meeroslav pushed a commit to meeroslav/nx that referenced this pull request Oct 18, 2021
* feat(react): support css prop for emotion

* feat(react): add migration for css prop
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from 11 -> 12 does not include all required changes for @emotion [emotion] css prop is not working
2 participants