fix(core): remove .eslintrc double extends update on move #6765
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/8R4MHmdgKV3p8gLskkxjC6Sac98o [Deployment for 5f55780 canceled] |
meeroslav
added
scope: core
Nx Cloud ReportCI ran the following commands for commit 5f55780. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
| @@ -41,28 +23,14 @@ export function updateEslintrcJson( | |||
| schema: NormalizedSchema, | |||
| project: ProjectConfiguration | |||
| ) { | |||
| tree['recordedChanges']; | |||
There was a problem hiding this comment.
This doesn't seem necessary.
| updateJson<PartialEsLintRcJson>(tree, eslintRcPath, (eslintRcJson) => { | ||
| if (typeof eslintRcJson.extends === 'string') { |
There was a problem hiding this comment.
I feel like we should keep it in here and take it out of updateRootProjectFIles since this is more specific.
And we don't need 2 places that both update the `eslintrc.json
There was a problem hiding this comment.
That was my initial take, but the other one is more generic. I would have to explicitly exclude it from root files.
There was a problem hiding this comment.
I'll move the logic here then
FrozenPandaz
force-pushed
the
fix/move-eslint-generator-double-path
branch
from
2c79969 to
5f55780
Compare
* fix(core): remove eslintrc double extends update on move * fix(core): move eslintrc move logic back to eslint update
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Both
updateProjectRootFilesandupdateEslintrcJsonmodify relative paths in the.eslintrc.json'sextends, causing change to be applied twice.Expected Behavior
Only
updateProjectRootFilesshould modify relative paths in the.eslintrc.json.Related Issue(s)
Fixes #