Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): add vue3 support for storybook executer #6604

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

AlmarAubel
Copy link
Contributor

ISSUES CLOSED: #6603

Current Behavior

Users are restricted by the existing schema to be able to add Storybook only to angular, react vue and html projects.

Expected Behavior

This PR add vue3 to the list, as well.

Related Issue(s)

#6603

@vercel
Copy link

vercel bot commented Aug 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/6UHiPjQ4gbcrT4o7LaApoUmG6EmP
✅ Preview: https://nx-dev-git-fork-almaraubel-master-nrwl.vercel.app

@AlmarAubel
Copy link
Contributor Author

@FrozenPandaz do you maybe know what I do wrong? the build is not starting...

`This PR adds support for 'vue3' so it can be used to run storybook in a NX workspace

Closes nrwl#6603
@FrozenPandaz
Copy link
Collaborator

Sorry, I am not sure why sometimes Circle doesn't pick up PRs 🤷 I rebased your branch with the latest master and pushed to your branch. Circle usually picked it up this time around 😅

@AlmarAubel
Copy link
Contributor Author

Thank for helping out!

@meeroslav meeroslav requested a review from mandarini August 19, 2021 14:11
@mandarini mandarini merged commit e263776 into nrwl:master Aug 23, 2021
ManojBahuguna pushed a commit to ManojBahuguna/nx that referenced this pull request Sep 16, 2021
`This PR adds support for 'vue3' so it can be used to run storybook in a NX workspace

Closes nrwl#6603
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storybook/vue3 is not supported
4 participants