Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextjs): add buildLibsFromSource option #5738

Merged
merged 1 commit into from
Jun 2, 2021
Merged

feat(nextjs): add buildLibsFromSource option #5738

merged 1 commit into from
Jun 2, 2021

Conversation

kirjai
Copy link
Contributor

@kirjai kirjai commented May 21, 2021 •
edited
Loading

Current Behavior

Next.js has a missing buildLibsFromSource option that we have for other packages that support incremental builds

Expected Behavior

Related Issue(s)

Fixes #5577, #5762

@vercel
Copy link

vercel bot commented May 21, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/4jNTUmJ1hvYeqHY1TLkm4SpUyKbL
✅ Preview: https://nx-dev-git-fork-kirjai-next-build-from-source-2-nrwl.vercel.app

@nx-cloud
Copy link

nx-cloud bot commented May 21, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit ffae60c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --parallel --max-parallel=3
#000000 nx affected --target=e2e
#000000 nx affected --target=lint --parallel --max-parallel=4
#000000 nx affected --target=test --parallel --max-parallel=2

Sent with 💌 from NxCloud.

@kirjai kirjai self-assigned this May 21, 2021
@kirjai kirjai marked this pull request as ready for review May 21, 2021 14:15
@kirjai
Copy link
Contributor Author

kirjai commented May 25, 2021

@FrozenPandaz all comments resolved

@kirjai kirjai requested a review from FrozenPandaz May 25, 2021 17:49
@kirjai kirjai mentioned this pull request May 28, 2021
Closed
@kirjai kirjai linked an issue May 28, 2021 that may be closed by this pull request
The issue with a publishable library in a Next.js app. The app uses the library from dist instead of libs folder #5762
Closed
@marbemac
Copy link

FWIW - tried this locally, works great 👍 👏.

FrozenPandaz
FrozenPandaz approved these changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kirjai kirjai merged commit f723613 into nrwl:master Jun 2, 2021
@kirjai kirjai deleted the next-build-from-source-2 branch June 2, 2021 16:40
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

Assignees

@kirjai kirjai

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kirjai @marbemac @FrozenPandaz