Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): freeze the Storybook version to just patches #4776

Closed
wants to merge 1 commit into from

Conversation

juristr
Copy link
Member

@juristr juristr commented Feb 12, 2021

Current Behavior

We use deep imports to the server standalone mode which might break in upcoming minor releases (e.g. see #4747)

Expected Behavior

Nx upgrades should also upgrade the Storybook versions when needed, to guarantee they are both compatible.
As a future improvement it might also be an option to reach out to the Storybook team to discuss exposing some of those references via the public API.

@juristr juristr requested a review from FrozenPandaz February 12, 2021 10:50
@juristr juristr force-pushed the avoid-storybook-version-upgrade branch from 1d3c8b9 to f53903a Compare February 12, 2021 11:19
We use deep imports to the server standalone mode which might break
in upcoming minor releases
@juristr juristr force-pushed the avoid-storybook-version-upgrade branch from f53903a to c25820e Compare February 12, 2021 11:24
@nx-cloud
Copy link

nx-cloud bot commented Feb 12, 2021

Nx Cloud Report

CI ran the following commands for commit c25820e. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 2/12/2021, 11:27:12 AM
#000000 nx run-many --target=e2e --projects=e2e-angular 2/12/2021, 11:28:08 AM
#000000 nx run-many --target=e2e --projects=e2e-next,e2e-gatsby 2/12/2021, 11:28:05 AM
#000000 nx run-many --target=e2e --projects=e2e-react 2/12/2021, 11:28:06 AM
#000000 nx run-many --target=e2e --projects=e2e-storybook 2/12/2021, 11:28:32 AM
#000000 nx run-many --target=lint --all --parallel 2/12/2021, 11:29:35 AM
#000000 nx run-many --target=test --all --parallel 2/12/2021, 11:27:24 AM

Sent with 💌 from NxCloud.

@FrozenPandaz
Copy link
Collaborator

I changed the imports recently.. does this make us a little less prone to being broken by storybook?

651f3b6

@juristr
Copy link
Member Author

juristr commented Feb 13, 2021

I changed the imports recently.. does this make us a little less prone to being broken by storybook?

651f3b6

@FrozenPandaz yep I've seen that. That was one adjustment to make, but there's also this one https://github.com/nrwl/nx/blob/master/packages/storybook/src/executors/build-storybook/build-storybook.impl.ts#L36 which currently breaks in 6.2 alpha of Storybook. I've been waiting to make the adjustment since they've not sorted it out yet on their side either.

@juristr
Copy link
Member Author

juristr commented Feb 25, 2021

// Update

We decided to wait till the beta version of Storybook 6.2 to see what their final decision on the restructuring of some paths are. And then decide how to proceed. So this PR is paused for now

@mlebarron
Copy link

They are on beta 11 now.

@juristr
Copy link
Member Author

juristr commented Mar 12, 2021

@mlebarron cool, I'm going to have a look whether the problem got solved now which we previously had with one of their alpha versions. Thx for letting me know

@puku0x
Copy link
Contributor

puku0x commented Mar 18, 2021

Wow, v6.2.0 is coming soon. storybookjs/storybook#13160
I'm excited to see the new feature in @storybook/addon-controls (Nx uses addon-knobs, though).

@juristr
Copy link
Member Author

juristr commented Mar 19, 2021

I'm excited to see the new feature in @storybook/addon-controls (Nx uses addon-knobs, though).

@puku0x addon-controls will be available soon in Nx as well. @mandarini is gonna work on that :)

@juristr
Copy link
Member Author

juristr commented Mar 19, 2021

closing in favor of #5072.

@juristr juristr closed this Mar 19, 2021
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants