-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storybook): freeze the Storybook version to just patches #4776
Conversation
1d3c8b9
to
f53903a
Compare
We use deep imports to the server standalone mode which might break in upcoming minor releases
f53903a
to
c25820e
Compare
Nx Cloud ReportCI ran the following commands for commit c25820e. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
I changed the imports recently.. does this make us a little less prone to being broken by storybook? |
@FrozenPandaz yep I've seen that. That was one adjustment to make, but there's also this one https://github.com/nrwl/nx/blob/master/packages/storybook/src/executors/build-storybook/build-storybook.impl.ts#L36 which currently breaks in 6.2 alpha of Storybook. I've been waiting to make the adjustment since they've not sorted it out yet on their side either. |
// Update We decided to wait till the beta version of Storybook 6.2 to see what their final decision on the restructuring of some paths are. And then decide how to proceed. So this PR is paused for now |
They are on beta 11 now. |
@mlebarron cool, I'm going to have a look whether the problem got solved now which we previously had with one of their alpha versions. Thx for letting me know |
Wow, v6.2.0 is coming soon. storybookjs/storybook#13160 |
@puku0x addon-controls will be available soon in Nx as well. @mandarini is gonna work on that :) |
closing in favor of #5072. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
We use deep imports to the server standalone mode which might break in upcoming minor releases (e.g. see #4747)
Expected Behavior
Nx upgrades should also upgrade the Storybook versions when needed, to guarantee they are both compatible.
As a future improvement it might also be an option to reach out to the Storybook team to discuss exposing some of those references via the public API.