Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webpack): add option to opt out of watching buildable dependencies #29984

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat(webpack): add option to opt out of watching buildable dependencies #29984

merged 1 commit into from
Feb 13, 2025

Conversation

leosvelperez
Copy link
Member

Add a watchDependencies options to the relevant webpack executors and plugins to allow opting out of watching buildable dependencies.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #29961

@leosvelperez leosvelperez requested a review from jaysoo February 11, 2025 14:24
@leosvelperez leosvelperez self-assigned this Feb 11, 2025
@leosvelperez leosvelperez requested review from a team as code owners February 11, 2025 14:24
@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 11, 2025 2:32pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 11, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 599b7f7.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 34m 50s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 3s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 9s View ↗
nx documentation ✅ Succeeded 1m 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-11 15:06:11 UTC

@leosvelperez leosvelperez merged commit 9e204f9 into master Feb 13, 2025
12 checks passed
@leosvelperez leosvelperez deleted the misc/webpack-watch-dependencies-option branch February 13, 2025 16:00
jaysoo pushed a commit that referenced this pull request Feb 13, 2025
@leosvelperez @jaysoo
feat(webpack): add option to opt out of watching buildable dependenci…
ddf28cc 
…es (#29984)

Add a `watchDependencies` options to the relevant webpack executors and
plugins to allow opting out of watching buildable dependencies.

## Current Behavior

## Expected Behavior

## Related Issue(s)

Fixes #29961
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

Assignees

@leosvelperez leosvelperez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebpackNxBuildCoordinationPlugin needs to be disable-able
2 participants
@leosvelperez @jaysoo