Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle): fix gradle undefined dependency target #29943

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Feb 9, 2025

Current Behavior

got this error:

 NX   Cannot read properties of undefined (reading '1')

TypeError: Cannot read properties of undefined (reading '1')
    at fileDataDepTarget (/Users/emily/code/tmp/spring-boot/.nx/installation/node_modules/nx/src/config/project-graph.js:13:18)
    at ProjectGraphBuilder.calculateTargetDepsFromFiles (/Users/emily/code/tmp/spring-boot/.nx/installation/node_modules/nx/src/project-graph/project-graph-builder.js:271:74)

this happens because the project in the dependency file is in format like :spring-boot-project:spring-boot-autoconfigure (*). need to take out the text after space.

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2025 6:03pm

Copy link

nx-cloud bot commented Feb 9, 2025

View your CI Pipeline Execution ↗ for commit 1eba43f.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 13m 21s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 23s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 12s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 10s View ↗
nx documentation ✅ Succeeded 2m 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-09 18:22:51 UTC

@xiongemi xiongemi force-pushed the fix/fix-gradle-undefined-dep branch from f6dea0e to 2ff8e26 Compare February 9, 2025 06:35
@xiongemi xiongemi force-pushed the fix/fix-gradle-undefined-dep branch from 2ff8e26 to 1eba43f Compare February 9, 2025 18:01
@xiongemi xiongemi requested a review from MaxKless February 10, 2025 21:17
@xiongemi xiongemi merged commit 7c5fcf3 into master Feb 12, 2025
12 checks passed
@xiongemi xiongemi deleted the fix/fix-gradle-undefined-dep branch February 12, 2025 01:15
jaysoo pushed a commit that referenced this pull request Feb 12, 2025
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
got this error:
```
 NX   Cannot read properties of undefined (reading '1')

TypeError: Cannot read properties of undefined (reading '1')
    at fileDataDepTarget (/Users/emily/code/tmp/spring-boot/.nx/installation/node_modules/nx/src/config/project-graph.js:13:18)
    at ProjectGraphBuilder.calculateTargetDepsFromFiles (/Users/emily/code/tmp/spring-boot/.nx/installation/node_modules/nx/src/project-graph/project-graph-builder.js:271:74)
```

this happens because the project in the dependency file is in format
like `:spring-boot-project:spring-boot-autoconfigure (*)`. need to take
out the text after space.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants